Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [Catalog] Fixing compare block product removing action from sidebar #21238

Merged

Conversation

eduard13
Copy link
Contributor

Original Pull Request

#21102

Description (*)

This PR allows to open the product from the Comparing Products sidebar's block.

Fixed Issues (if relevant)

  1. Unable to open the product from sidebar's Compare Products block #21101: Unable to open the product from sidebar's Compare Products block
  2. ...

Manual testing scenarios (*)

  1. Add a product to your Compare Products list
  2. Check the sidebar for new added product for comparing
  3. Click on the Product's name

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Area: Design/Frontend Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 14, 2019
@torhoehn torhoehn self-requested a review February 14, 2019 22:10
@torhoehn torhoehn self-assigned this Feb 14, 2019
@torhoehn
Copy link
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, here is your new Magento instance.
Admin access: https://pr-21238.instances.magento-community.engineering/admin
Login: admin Password: 123123q

Copy link
Contributor

@torhoehn torhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Manual Testing

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn, thank you for the review.
ENGCOM-4271 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 15, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 544d99c into magento:2.2-develop Feb 15, 2019
magento-engcom-team pushed a commit that referenced this pull request Feb 15, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants