Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Admin Customizable Options Dropdown sort_order issue #21371

Merged
merged 3 commits into from Mar 14, 2019

Conversation

omiroshnichenko
Copy link
Contributor

Description (*)

Admin Customizable Options Dropdown sort_order issue

Fixed Issues (if relevant)

  1. Admin Customizable Options Dropdown sort_order issue #20989: Admin Customizable Options Dropdown sort_order issue

Manual testing scenarios (*)

  1. Go to Catalog > Products
  2. Edit/New Product
  3. Expand Customizable Options and click on Add Option
  4. Choose Drop Dowm as New Option Type
  5. Add 1 or 2 Values
    6 . Now , Change Option type from drop down to field or area
  6. Now again choose Drop Dowm as Option Type
  7. Add 1 or 2 Values

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @omiroshnichenko. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4373 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @omiroshnichenko , thanks for the pull request! Can you please update the branch and check if the issue is still actual, looks like it was fixed in #20990

@omiroshnichenko
Copy link
Contributor Author

Hi @sivaschenko. PR, that you mentioned, not fully fixed the problem. Empty space still present for the cell in dynamic rows. My fix will completely hide the column.

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4373 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team merged commit 795d532 into magento:2.3-develop Mar 14, 2019
@ghost
Copy link

ghost commented Mar 14, 2019

Hi @omiroshnichenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants