Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#15772: Tier prices calculated on 2 decimals #21554

Closed

Conversation

AleksLi
Copy link
Contributor

@AleksLi AleksLi commented Mar 2, 2019

Created new method \Magento\Quote\Model\Quote\Address\Item::calcRowTotal in the parent class. Actually it's more like an extended version of the \Magento\Quote\Model\Quote\Item\AbstractItem::calcRowTotal
Added extended rounding for Address Item to get more accurate calculation result

Description (*)

Fixed Issues (if relevant)

  1. magento/magento2#<15772> : Price tiers calculated on 2 decimals even when prices of 4 decimals are entered

Manual testing scenarios (*)

  1. Fully described in the ticket Price tiers calculated on 2 decimals even when prices of 4 decimals are entered #15772 .

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…n prices of 4 decimals are entered

Added extended rounding for Address Item to get more accurate calculation result
@magento-engcom-team
Copy link
Contributor

Hi @AleksLi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Quote Release Line: 2.3 Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner labels Mar 2, 2019
@torhoehn torhoehn self-requested a review March 2, 2019 20:14
@torhoehn torhoehn self-assigned this Mar 2, 2019
@orlangur orlangur self-assigned this Mar 4, 2019
@orlangur
Copy link
Contributor

orlangur commented Mar 4, 2019

This should be fixed in general and not in some random places. Ref: https://github.com/magento/magento2/issues/10532

@orlangur orlangur closed this Mar 4, 2019
@ghost
Copy link

ghost commented Mar 4, 2019

Hi @AleksLi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Quote Partner: Vaimo Pull Request is created by partner Vaimo partners-contribution Pull Request is created by Magento Partner Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants