Purchasing a downloadable product as guest then creating an account on the onepagesuccess step doesn't link product with account

[Jitheesh]

New downloadable products does not show up in my downloadable products section after using guest checkout and creating an account. This issue is because Link Purchased items are not updating after create account.

After account create Magento is assigning customer ID to recent order and it initiates order save. My fix will observer order save and it will update downloadable_link_purchased table with updated order data.
I'm not sure this is right fix or not.

Description (*)

Fixed Issues (if relevant)

1. Purchasing a downloadable product as guest then creating an account on the onepagesuccess step doesn't link product with account #21702: Purchasing a downloadable product as guest then creating an account on the onepagesuccess step doesn't link product with account

Manual testing scenarios (*)

1. Enable guest purchasing of downloadable products (Catalog -> Catalog -> Dowloadable Product Options -> Disable Guest Checkout if Cart Contains Downloadable Items -> (Change it to NO))
2. Purchase a downloadable product via guest checkout
3. On the onepagesuccess step, create an account.
4. Login to that newly created account and view the list of purchased downloadable products

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @Jitheesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[Jitheesh]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @Jitheesh. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Jitheesh, here is your new Magento instance.
Admin access: https://pr-21711.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[rogyar]

Hi @Jitheesh. Thank you for your contribution. Could you explain, please, is there any reason why the observer was created instead of fixing the issue directly in the code where it appears?
Thank you

[Jitheesh]

Hi @rogyar

This issue is related to downloadable component and issue is appears at sales component,

magento2/app/code/Magento/Sales/Model/Order/CustomerManagement.php

Lines 99 to 125 in ab66a14

	public function create($orderId)
	{
	$order = $this->orderRepository->get($orderId);
	if ($order->getCustomerId()) {
	throw new AlreadyExistsException(
	__('This order already has associated customer account')
	);
	}
	$customer = $this->customerExtractor->extract($orderId);
	/** @var AddressInterface[] $filteredAddresses */
	$filteredAddresses = [];
	foreach ($customer->getAddresses() as $address) {
	if ($this->needToSaveAddress($order, $address)) {
	$filteredAddresses[] = $address;
	}
	}
	$customer->setAddresses($filteredAddresses);
	$account = $this->accountManagement->createAccount($customer);
	$order = $this->orderRepository->get($orderId);
	$order->setCustomerId($account->getId());
	$order->setCustomerIsGuest(0);
	$this->orderRepository->save($order);
	return $account;
	}

so I thought it would be good to add this fix on corresponding component. We already have other Observer based on this rule.

magento2/app/code/Magento/Downloadable/Observer/SetLinkStatusObserver.php

Line 11 in ab66a14

class SetLinkStatusObserver implements ObserverInterface

[Jitheesh]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @Jitheesh. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @Jitheesh, here is your new Magento instance.
Admin access: https://pr-21711.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-4691 has been created to process this Pull Request

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @Jitheesh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.