Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitemap Generation - Product URL check null fix #21749

Merged
merged 2 commits into from Mar 30, 2019
Merged

Sitemap Generation - Product URL check null fix #21749

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af6d40
fixes sitemap checking for null, when is empty instead
asim-vax Mar 14, 2019
def3be9
magento/magento2#21749: Static test fix.
p-bystritsky Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Sitemap/Model/ResourceModel/Catalog/Product.php
View file
Open in desktop
Expand Up @@ -324,7 +324,7 @@ public function getCollection($storeId)
[]
)->joinLeft(
['url_rewrite' => $this->getTable('url_rewrite')],
'e.entity_id = url_rewrite.entity_id AND url_rewrite.is_autogenerated = 1 AND url_rewrite.metadata IS '
'e.entity_id = url_rewrite.entity_id AND url_rewrite.is_autogenerated = 1 AND NULLIF(url_rewrite.metadata,"") IS '
. $urlsConfigCondition . 'NULL'
. $connection->quoteInto(' AND url_rewrite.store_id = ?', $store->getId())
. $connection->quoteInto(' AND url_rewrite.entity_type = ?', ProductUrlRewriteGenerator::ENTITY_TYPE),
Expand Down