Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multishipping checkout agreements now are the same as default checkout agreements #21778

Merged
merged 5 commits into from Mar 26, 2019
Merged

Conversation

samuel27m
Copy link
Contributor

Description (*)

Make multishipping checkout agreements template file to be the same as default checkout for consistency.

Manual testing scenarios (*)

  1. "Review Order" multishipping step now has the same template for checkout agreements that default checkout has.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @samuel27m. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@dmytro-ch
Copy link
Contributor

dmytro-ch commented Mar 16, 2019

Hi @samuel27m,
thank you for your contribution!

Unfortunately, we may not remove the templates due to the possible backward compatibility issues. Some third-party themes or extensions might use this template without overriding.

Could you please restore the app/code/Magento/CheckoutAgreements/view/frontend/templates/multishipping_agreements.phtml file?

Thank you!

@samuel27m
Copy link
Contributor Author

Hi @dmytro-ch,

Thanks for noticing, I totally forgot about that.
Added new commit to restore the file.

Thank you!

@samuel27m samuel27m added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: needs update labels Mar 18, 2019
@ghost ghost added Progress: needs update and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Mar 18, 2019
@ghost
Copy link

ghost commented Mar 18, 2019

@samuel27m unfortunately, only members of the maintainers team are allowed to add progress related labels to the pull request

@ghost
Copy link

ghost commented Mar 18, 2019

@samuel27m unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4526 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@ghost
Copy link

ghost commented Mar 26, 2019

Hi @samuel27m, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants