Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21779 Adminhtml textarea field doesn't accept maxlength #21816

Merged
merged 3 commits into from Apr 23, 2019
Merged

#21779 Adminhtml textarea field doesn't accept maxlength #21816

merged 3 commits into from Apr 23, 2019

Conversation

kisroman
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Adminhtml textarea field doesn't accept maxlength #21779
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @kisroman. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda miguelbalparda self-assigned this Mar 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-4631 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 9, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Apr 18, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 23, 2019
Closed
@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @kisroman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 149294b into magento:2.3-develop Apr 23, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Apr 23, 2019
@sivaschenko
ENGCOM-4631: magento#21779 Adminhtml textarea field doesn't accept ma…
b0ee080 
…xlength magento#21816
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Community Insider: Magecom community-insider-contribution Component: Data Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kisroman @magento-engcom-team @VasylShvorak @miguelbalparda @p-bystritsky