Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling "Display on Product Details Page" the button is shown anyway. #22260

Merged
merged 1 commit into from May 1, 2019
Merged

Disabling "Display on Product Details Page" the button is shown anyway. #22260

merged 1 commit into from May 1, 2019

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Apr 10, 2019 •
edited

Description (*)

With a well working Paypal Express Checkout, Configure magento settings as follow:

set yes to "Display on Product Details Page" (>configuration>sales>payment methods>paypal>express checkout)

Fixed Issues (if relevant)

  1. Instant Purchase on product page not working properly. #22045: Issue title
  2. Paypal buttons disable issue - Magento 2.3.1 #22134 Paypal buttons disable issue - Magento 2.3.1

Manual testing scenarios (*)

set yes to "Display on Product Details Page" (>configuration>sales>payment methods>paypal>express checkout)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2019

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Apr 11, 2019
@rogyar
Copy link
Contributor

rogyar commented Apr 11, 2019

Hi @Nazar65. Thank you for your contribution. Please, consider fixing the failing unit tests.

@Nazar65
Copy link
Member Author

Nazar65 commented Apr 11, 2019

Hi @rogyar thank you for note. I fixed the failing unit test, For some reason i' forget to check this test before create a PR.

@Nazar65 Nazar65 requested a review from rogyar April 11, 2019 17:33
@Nazar65
Copy link
Member Author

Nazar65 commented Apr 12, 2019

Hi @rogyar is there anything else that i would be to change ?

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4752 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 15, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Apr 17, 2019
sivaschenko
sivaschenko requested changes Apr 18, 2019
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nazar65 I have a small review comment regarding this pull request, can you please check it out.

app/code/Magento/Paypal/Model/SmartButtonConfig.php Outdated Show resolved Hide resolved
@ghost ghost assigned sivaschenko Apr 18, 2019
@Nazar65
Copy link
Member Author

Nazar65 commented Apr 18, 2019 •
edited

Hi @sivaschenko done ✔️

@ghost ghost removed the Progress: needs update label Apr 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4752 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

This was referenced May 1, 2019
Closed
Closed
@magento-engcom-team magento-engcom-team merged commit 233e4c5 into magento:2.3-develop May 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 1, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 1, 2019
@sidolov
ENGCOM-4752: Disabling "Display on Product Details Page" the button i…
d493dfc 
…s shown anyway. #22260
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 1, 2019
@quantumAV quantumAV mentioned this pull request Jul 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@rogyar rogyar rogyar approved these changes

Assignees

@sivaschenko sivaschenko

@rogyar rogyar

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Area: Frontend Component: Paypal Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Nazar65 @rogyar @magento-engcom-team @VasylShvorak @sivaschenko @nmalevanec