Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make return_path_email and set_return_path configurable on website and store scope as well #22285

Merged
merged 1 commit into from Apr 27, 2019
Merged

Conversation

mhauri
Copy link

@mhauri mhauri commented Apr 11, 2019

Make the values return_path_email and set_return_path configurable in Website and Store scope.

Description (*)

By now the values system/smtp/return_path_email and system/smtp/set_return_path are currently only configurable on GLOBAL scope.

This makes it impossible to set these values if you have multiple websites with different domains and mail senders.

Manual testing scenarios (*)

  1. Configure Multiple Websites
  2. Try to set return path and return email on Website or Store scope

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2019

Hi @mhauri. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for QA: please consult with appropriate PO in order to evaluate such change.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4738 has been created to process this Pull Request

@sdzhepa
Copy link
Contributor

sdzhepa commented Apr 23, 2019

✔️ QA Passed

Tested the ability to set "Return-Path Email" on a website level by next flow

Preconditions

  1. Go to Admin > Stores > All Stores and configure two websites, like
    22285_websites
  2. Go to Admin > Stores > Configuration > General > Store Emails Addresses and configure different emails per each store, e.g.
    22285_emails
  3. Go to Admin > Stores > Configuration > Advanced > System and configure Return-Path Email per each store. like:
    22285_return_path
  4. Go to Admin > Stores > Configuration > General > Web and configure Add Store Code to Urls = YES

Steps

  1. Go to the first website (e.g. "http://magento.i1.loc/default") and create new customer1
  2. Go to the first website (e.g. "http://magento.i1.loc/additional") and create new customer2
  3. Verify that source of each email has correct **Return-Path
    22285_result
    **

@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2019

Hi @mhauri, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit c75c2e1 into magento:2.3-develop Apr 27, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 27, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants