Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 22743 #22944

Closed
wants to merge 1 commit into from
Closed

Fix Issue 22743 #22944

wants to merge 1 commit into from

Conversation

ernesthernandez
Copy link

Description (*)

New logic introduced in 2.3.1 2fb6b3b populates wrong quantity for the bundled products .

See #22743

Fixed Issues (if relevant)

  1. M2.3.1: Unable to place order for bundle when child quantity > 1 #22743: M2.3.1: Unable to place order for bundle when child quantity > 1

Manual testing scenarios (*)

  1. Add Test bundle to the shopping cart, making sure to set the child quantity to a value > 1:
  2. Proceed to Checkout
  3. Select PayPal Express Checkout as the payment method.
    Expected result ()
    Customer is redirected back to Magento's Order Success page
    Actual result (
    )
    Error message We found an invalid quantity to invoice item "%1". is displayed.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 20, 2019

Hi @ernesthernandez. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 20, 2019

CLA assistant check
All committers have signed the CLA.

@@ -90,7 +81,7 @@ public function __construct(
\Magento\Sales\Model\Order\InvoiceNotifier $notifier,
\Magento\Sales\Api\OrderRepositoryInterface $orderRepository,
\Magento\Sales\Model\Convert\Order $orderConverter,
Json $serializer = null
JsonSerializer $serializer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ernesthernandez, due to Magento backward-compatible guide we can't add required parameters to the constructor. Please revert your changes.

@sidolov
Copy link
Contributor

sidolov commented Jun 3, 2019

@ernesthernandez , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jun 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 3, 2019

Hi @ernesthernandez, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants