New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 22743 #22944
Fix Issue 22743 #22944
Conversation
Hi @ernesthernandez. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@@ -90,7 +81,7 @@ public function __construct( | |||
\Magento\Sales\Model\Order\InvoiceNotifier $notifier, | |||
\Magento\Sales\Api\OrderRepositoryInterface $orderRepository, | |||
\Magento\Sales\Model\Convert\Order $orderConverter, | |||
Json $serializer = null | |||
JsonSerializer $serializer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ernesthernandez, due to Magento backward-compatible guide we can't add required parameters to the constructor. Please revert your changes.
@ernesthernandez , I am closing this PR now due to inactivity. |
Hi @ernesthernandez, thank you for your contribution! |
Description (*)
New logic introduced in 2.3.1 2fb6b3b populates wrong quantity for the bundled products .
See #22743
Fixed Issues (if relevant)
Manual testing scenarios (*)
Expected result ()
Customer is redirected back to Magento's Order Success page
Actual result ()
Error message We found an invalid quantity to invoice item "%1". is displayed.
Contribution checklist (*)