Fix unexpected diff between builds in generated/metadata directory

[ihor-sviziev]

Description (*)

Sort all path definitions before generating config and writing it to generated/metadata directory

This issue caused by using RecursiveDirectoryIterator object for generating list of all classes and all their arguments and it could return not sorted result. As result files between builds are different just because files were found in different sort order.

Fixed Issues (if relevant)

1. [Reproducible Builds] Diff in generated/metadata between the builds #23324: [Reproducible Builds] Diff in generated/metadata between the builds

Manual testing scenarios (*)

1. See [Reproducible Builds] Diff in generated/metadata between the builds #23324 for details

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

@orlangur Any updates on this pull request? Why is it on hold?

[orlangur]

@sivaschenko because of discussion in corresponding issue, need to check how long

magento2/setup/src/Magento/Setup/Module/Di/App/Task/Operation/Area.php

Line 91 in d8486ba

$this->sortDefinitions($definitionsCollection);

will take, will review this week.

[ihor-sviziev]

Hi @orlangur,

This PR was created almost 2 months ago. There is no clear description why this PR should be kept in "on hold" such big amount of time. If you think there might be performance degradation issues - QAs could re-check it. I checked it myself and there is no big difference.

I do understand that you could not have enough time for reviewing this PR, but I think it's not a good think to holding PR when you don't have time for reviewing it.

@sivaschenko @sidolov could you review my PR?

Thank you!

[orlangur]

@ihor-sviziev the only concern was performance.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-5592 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.