-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unexpected diff between builds in generated/metadata directory #23325
Fix unexpected diff between builds in generated/metadata directory #23325
Conversation
Hi @ihor-sviziev. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Sort all path definitions before generating config
71f586f
to
d8486ba
Compare
@orlangur Any updates on this pull request? Why is it on hold? |
@sivaschenko because of discussion in corresponding issue, need to check how long
|
Hi @orlangur, This PR was created almost 2 months ago. There is no clear description why this PR should be kept in "on hold" such big amount of time. If you think there might be performance degradation issues - QAs could re-check it. I checked it myself and there is no big difference. I do understand that you could not have enough time for reviewing this PR, but I think it's not a good think to holding PR when you don't have time for reviewing it. @sivaschenko @sidolov could you review my PR? Thank you! |
@ihor-sviziev the only concern was performance. |
Hi @orlangur, thank you for the review.
|
Hi @ihor-sviziev, thank you for your contribution! |
Description (*)
Sort all path definitions before generating config and writing it to generated/metadata directory
This issue caused by using RecursiveDirectoryIterator object for generating list of all classes and all their arguments and it could return not sorted result. As result files between builds are different just because files were found in different sort order.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)