Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The best practices for SEO meta sequence. #23425

Merged
merged 3 commits into from Jul 1, 2019

Conversation

vaseemishak
Copy link
Contributor

Description (*)

The best practices for SEO meta sequence is the title and then description.

Manual testing scenarios (*)

Render any page meta tag title should come before meta description.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

The best practices for SEO meta order is the title and then description.
The best practices for SEO meta order is the title and then description.
@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @vaseemishak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 26, 2019

CLA assistant check
All committers have signed the CLA.

@VladimirZaets VladimirZaets self-assigned this Jun 26, 2019
@VladimirZaets VladimirZaets added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Jun 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5363 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@vaseemishak thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Jun 27, 2019
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Jul 1, 2019
@magento-engcom-team magento-engcom-team merged commit 93212db into magento:2.3-develop Jul 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2019

Hi @vaseemishak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: View Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants