#19921 : ACL incorrect for Advance in system configuration

[konarshankar07]

Description (*)

Fixed Issues (if relevant)

1. ACL incorrect for Advance in system configuration #19921: ACL incorrect for Advance in system configuration

Manual testing scenarios (*)

1. Login into backend
2. Go To System -> Permissions -> User Roles
3. 'Advanced Section' role has been disabled
4. ''Advanced Section'' has been deprecated

Questions or comments

I think the best is to remove the code from the system.xml and acl.xml so we don't get ran into this issue again. Let me know your thoughts.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @konarshankar07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Thanks for the pull request @konarshankar07 , can you please correct the resource in https://github.com/magento/magento2/blob/2.3-develop/setup/src/Magento/Setup/Test/Unit/Module/Di/_files/app/code/Magento/SomeModule/etc/adminhtml/system.xml

[konarshankar07]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @konarshankar07. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @konarshankar07, here is your Magento instance.
Admin access: https://i-23600-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[sivaschenko]

@magento run all tests

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-5750 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-5750 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @konarshankar07, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.