Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphQl-200: Product Compare #23704

Closed
wants to merge 1 commit into from

Conversation

kisroman
Copy link
Contributor

@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2019

Hi @kisroman. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@josefbehr
Copy link
Contributor

@magento run all tests

@josefbehr josefbehr self-assigned this Sep 9, 2019
josefbehr
josefbehr previously approved these changes Sep 9, 2019
@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-5820 has been created to process this Pull Request
✳️ @josefbehr, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@josefbehr josefbehr added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 9, 2019
@ghost ghost unassigned lenaorobei Sep 11, 2019
@ghost
Copy link

ghost commented Sep 11, 2019

@TomashKhamlai unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@lenaorobei
Copy link
Contributor

@kisroman thank you for all the efforts you put into these 2 PRs.

Please understand that introducing new interfaces and schema changes require transparent approval flow by architecture team and must be publicly highlighted.

Next steps that we are going to perform in order to process your PRs:

Once proposed schema will cover all use cases, we will be able to move forward.
I will keep you updated about this.

Sorry for such delay and hope for your understanding.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:20
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 11, 2020
@nrkapoor nrkapoor linked an issue Jun 11, 2020 that may be closed by this pull request
@nrkapoor nrkapoor modified the milestones: 2.4.1, 2.4.2 Aug 15, 2020
@nrkapoor nrkapoor requested a review from cpartica August 18, 2020 14:13
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kisroman , can you please add the description of changes introduced in the pull request and testing instructions. If approved it will also require the test coverage

@ghost ghost moved this from On Hold to Changes Requested in Pull Requests Dashboard Oct 12, 2020
@ghost ghost assigned sivaschenko Oct 12, 2020
@ghost ghost dismissed josefbehr’s stale review October 12, 2020 12:29

Pull Request state was updated. Re-review required.

@sidolov sidolov added this to Changes Requested in GraphQL Pull Requests Dashboard Oct 27, 2020
@ghost ghost removed this from Changes Requested in Pull Requests Dashboard Oct 27, 2020
@gabrieldagama
Copy link
Contributor

Hi @kisroman, thanks for contributing.
This feature has been introduced in 2.4-develop already. Here is the PR #29047

Closing this one as the feature is already implemented.

Thanks for contributing!

@m2-assistant
Copy link

m2-assistant bot commented Mar 23, 2021

Hi @kisroman, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog/Customer :: Product Compare List
8 participants