fixed disabled guest checkout issue in case of downloadable product

[rani-priya]

fixed disabled guest checkout issue in case of downloadable product #23971

Description (*)

Related Pull Requests

• MFTF test fix. Changes for settings of downloadable shareable product. inventory#2966

Fixed Issues (if relevant)

1. fixes Disable Guest Checkout if Cart Contains Downloadable Items doesn't work correctly #23971: Disable Guest Checkout if Cart Contains Downloadable Items doesn't work correctly

Manual testing scenarios (*)

1. navigate to backend->stores->configuration->catalog->Downloadable Product Options
2. Set Shareable -> No and Disable Guest Checkout if Cart Contains Downloadable Items -> No
   

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rani-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[josefbehr]

@rani-webkul apparently, some tests have to be adapted, too, for this to work. Please fix those, and I see no problem in merging this. Thank you!

[josefbehr]

@rani-webkul Awesome, thanks.

[magento-engcom-team]

Hi @josefbehr, thank you for the review.
ENGCOM-5629 has been created to process this Pull Request
✳️ @josefbehr, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

✔ Approved.

Failing tests looks not related to changes form this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5629 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

What was tested:

1. The problem described in Disable Guest Checkout if Cart Contains Downloadable Items doesn't work correctly #23971

Manual testing scenario:

1. Create Downloadable product with Shareable set no No
   
2. Go to Admin -> Stores -> Configuration -> Catalog -> Catalog -> Downloadable Product Options;
3. Set Shareable -> No & Disable Guest Checkout if Cart Contains Downloadable Items -> No
   

Before: ✖️ Guest checkout is enabled

After: ✔️ Guest checkout is disabled

2. Also checked the additional cases:

• Downloadable product with Shareable = Yes

Manual testing scenario:

1. Create Downloadable product with Shareable set to Yes;
2. Go to Admin -> Stores -> Configuration -> Catalog -> Catalog -> Downloadable Product Options;
3. Set Shareable -> No & Disable Guest Checkout if Cart Contains Downloadable Items -> No
   

Actual Result: ✔️ Guest checkout is enabled

• Downloadable product with Shareable = Use config

Manual testing scenario:

1. Create Downloadable product with Shareable set to Use config;
2. Go to Admin -> Stores -> Configuration -> Catalog -> Catalog -> Downloadable Product Options;
3. Set Shareable -> No & Disable Guest Checkout if Cart Contains Downloadable Items -> No
   

Actual Result: ✔️ Guest checkout is disabled

• Disable Guest Checkout if Cart Contains Downloadable Items set to Yes

Manual testing scenario:

1. Create Downloadable product with Shareable set to Use config;
2. Go to Admin -> Stores -> Configuration -> Catalog -> Catalog -> Downloadable Product Options;
3. Set Shareable -> Yes & Disable Guest Checkout if Cart Contains Downloadable Items -> Yes
   

Actual Result: ✔️ Guest checkout is disabled

[engcom-Kilo]

@magento run all tests

[m2-assistant]

Hi @rani-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.