Adding out of stock items to wishlist shows success message but fails #21519

[Rus0]

Description (*)

Adding verification of stock and catalog flag for showing out of stock products, the wishlist shows the products if they are out of stock with the flag show out of stock.

Fixed Issues (if relevant)

1. Adding out of stock items to wishlist shows success message but fails #21519: Adding out of stock items to wishlist shows success message but fails

Manual testing scenarios (*)

1. Add to wishlist a product without stock. Throws new exception
2. Enable cataloginventory/options/show_out_of_stock
3. Add to wishlist a product without stock. It will add it correctly.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Rus0. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5760 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[sidolov]

@Rus0 , please, take a look at failed tests

[Rus0]

I am going to upload later today a commit

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5760 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Delta]

Hi @Rus0 Unfortunately, I cannot reproduce issue on 2.3-develop.
Manual testing scenario:

• Create product with Stock Status=Out of Stock
• Set Stores->Configuration->Catalog->Inventory->Stock Options->Display Out of Stock Products=Yes
• Create customer and login
• Add product to wishlist

Result:
✔️ Product is added to wishlist and success message is shown

[Rus0]

Try adding it when it is out of stock and Stores->Configuration->Catalog->Inventory->Stock Options->Display Out of Stock Products = NO

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @Rus0, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.