Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EncryptionKey] Fixing the encryption key switching field #24437

Merged

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Sep 4, 2019

Description (*)

This PR fixes the event for switching the visibility for the New Key after choosing the Auto-generate a Key -> Yes option

Fixed Issues (if relevant)

  1. Autogenerating encryption key requires manually entering the key #24436: Autogenerating encryption key requires manually entering the key

Manual testing scenarios (*)

  1. Navigate to System / Manage Encryption Key
  2. Select Yes for Auto-generate a Key

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2019

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: EncryptionKey Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 4, 2019
@dmytro-ch dmytro-ch self-assigned this Sep 4, 2019
@dmytro-ch dmytro-ch self-requested a review September 4, 2019 08:17
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5763 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 4, 2019
@engcom-Alfa engcom-Alfa self-assigned this Sep 5, 2019
@engcom-Alfa
Copy link
Contributor

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Alfa, here is your Magento instance.
Admin access: https://i-24437-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@engcom-Alfa
Copy link
Contributor

Hi @eduard13

Unfortunately I am not able to reproduce the issue on fresh 2.3-develop instance. All works correct.

Actual Result:
before

@eduard13 Could you take a look, please?

Thanks!

@eduard13
Copy link
Contributor Author

eduard13 commented Sep 5, 2019

Hi @engcom-Alfa, I've just reproduced on the same instance as you checked. Please note that you shouldn't do any other clicks after clicking on Yes/No options.
In the following example, we can see that it hides only after clicking on the input's label.
2019-09-05 12 55 55

Please let me know if any other info is needed to help you with this.
Thanks

@engcom-Alfa
Copy link
Contributor

@eduard13 Thanks for clarification. Which browser are you using? Because on Chrome and Firefox all works correct.

@eduard13
Copy link
Contributor Author

eduard13 commented Sep 5, 2019

@engcom-Alfa it's Chrome Version 76.0.3809.100 (Official Build) (64-bit).

A better way to test it, is not using the mouse at all (as it listens the onclick event), just using the TAB key to select the selecbox, and then choose Yes from dropdown.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Sep 5, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix Component: EncryptionKey Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants