New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EncryptionKey] Fixing the encryption key switching field #24437
[EncryptionKey] Fixing the encryption key switching field #24437
Conversation
Hi @eduard13. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @dmytro-ch, thank you for the review.
|
@magento give me 2.3-develop instance |
Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @engcom-Alfa, here is your Magento instance. |
Hi @engcom-Alfa, I've just reproduced on the same instance as you checked. Please note that you shouldn't do any other clicks after clicking on Yes/No options. Please let me know if any other info is needed to help you with this. |
@eduard13 Thanks for clarification. Which browser are you using? Because on Chrome and Firefox all works correct. |
@engcom-Alfa it's Chrome Version 76.0.3809.100 (Official Build) (64-bit). A better way to test it, is not using the mouse at all (as it listens the onclick event), just using the TAB key to select the selecbox, and then choose Yes from dropdown. |
✔️ QA Passed |
Hi @eduard13, thank you for your contribution! |
Description (*)
This PR fixes the event for switching the visibility for the
New Key
after choosing theAuto-generate a Key
->Yes
optionFixed Issues (if relevant)
Manual testing scenarios (*)
System / Manage Encryption Key
Yes
forAuto-generate a Key
Questions or comments
Contribution checklist (*)