Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification counter design issue #23473 #24589

Conversation

thurow
Copy link
Contributor

@thurow thurow commented Sep 14, 2019

Description (*)

Fixing admin notification counter with more than 1 digit.

Fixed Issues (if relevant)

  1. Notification counter design issue  #23473: Notification counter design issue

Manual testing scenarios (*)

  1. Log in into magento admin panel
  2. See if the notification counter can afford more than 1 digit without breaking the circle
  3. Manual update the number of notification if necessary to reproduce (put like 20, or 99+)

Questions or comments

Captura de Tela 2019-09-14 às 11 33 31
Captura de Tela 2019-09-14 às 11 33 39
Captura de Tela 2019-09-14 às 11 36 29

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2019

Hi @thurow. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@thurow
Copy link
Contributor Author

thurow commented Sep 14, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @thurow. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @thurow, here is your Magento instance.
Admin access: https://i-24589-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@thurow thurow self-assigned this Sep 14, 2019
@ghost ghost unassigned thurow Sep 14, 2019
@ghost
Copy link

ghost commented Sep 14, 2019

@thurow unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@thurow thurow self-assigned this Sep 14, 2019
@ghost ghost unassigned thurow Sep 14, 2019
@ghost
Copy link

ghost commented Sep 14, 2019

@thurow unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@thurow thurow requested a review from sidolov September 14, 2019 16:05
@kalpmehta kalpmehta self-assigned this Sep 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5840 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 16, 2019
@magento-engcom-team magento-engcom-team merged commit 07d6cb9 into magento:2.3-develop Sep 19, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 19, 2019

Hi @thurow, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants