Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/22964 #24597

Merged
merged 6 commits into from Oct 3, 2019
Merged

Conversation

LucasCalazans
Copy link
Member

@LucasCalazans LucasCalazans commented Sep 14, 2019

Description

Removing the previously selected region after a country change

Fixed Issues

  1. Region doesn't updates after changing country and leaving region select unselected #23460: Region doesn't updates after changing country and leaving region select unselected

Manual testing scenarios

  1. Create user
  2. Create user address with country "United States" and region "Alabama"
  3. Go to created customer page
  4. Go to address customer address tab
  5. Hit edit action for the created address at the addresses grid
  6. Change the country to France
  7. Don't choose any region
  8. Save address
  9. Now the region is updated

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully

@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2019

Hi @LucasCalazans. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@LucasCalazans
Copy link
Member Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @LucasCalazans. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @LucasCalazans, here is your Magento instance.
Admin access: https://i-24597-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@kalpmehta kalpmehta self-assigned this Sep 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @kalpmehta, thank you for the review.
ENGCOM-5842 has been created to process this Pull Request
✳️ @kalpmehta, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

Hi @LucasCalazans issue is still reproducible on PR branch
Manual testing scenario:

  • Create customer
  • Add New Address to customer Address Book
    • State/Province=Alabama
    • Country=United States
  • Go to My Account (customer/account/) page and click Edit Address
  • Change only Country to France
  • Notice: State/Province filed is not selected and shows "Please select a region, state or province."
  • Click Save Address

Result:
❌ Alabama state is present in default address after save
❌ In customer_address_entity region field is Alabama

#24597PRProblem

Could you take a look?

@LucasCalazans
Copy link
Member Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @LucasCalazans. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @LucasCalazans, here is your new Magento instance.
Admin access: https://pr-24597.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@LucasCalazans
Copy link
Member Author

@engcom-Delta it is true, sorry.

I've pushed a fix. Can you review it again, please?

@engcom-Golf engcom-Golf self-assigned this Oct 1, 2019
@engcom-Golf
Copy link
Contributor

Hi @LucasCalazans could you please sign in new CLA ?

@engcom-Golf engcom-Golf closed this Oct 2, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 2, 2019

Hi @LucasCalazans, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @LucasCalazans, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 3, 2019
@LucasCalazans LucasCalazans deleted the bugfix/22964 branch October 3, 2019 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants