Fix error in configurables

[elfeffe]

Problem with configurables when the simple products that were associated did not have a value for the configurable attribute.
Fix this issue #14240

Description (*)

Fixed Issues (if relevant)

1. /vendor/magento/module-configurable-product/Model/Product/Type/VariationMatrix.php on line 43 #14240: /vendor/magento/module-configurable-product/Model/Product/Type/VariationMatrix.php on line 43 /vendor/magento/module-configurable-product/Model/Product/Type/VariationMatrix.php on line 43 #14240

Questions or comments

Contribution checklist (*)

• [ x] Pull request has a meaningful description of its purpose
• [x ] All commits are accompanied by meaningful commit messages
• [ x] All new or changed code is covered with unit/integration tests (if applicable)
• [ x] All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @elfeffe. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5937 has been created to process this Pull Request

[magento-engcom-team]

@elfeffe thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Delta]

Hi @elfeffe Could you provide more information how to reproduce issue #14240 ?

[elfeffe]

@engcom-Delta

The problem was that we had a configurable product set to use two configurable attributes.
One or more of the simple products that were associated did not have a value for the configurable attribute.
For some reason we had the values when we linked the products, but we don't know why we lost the values, and when we try to edit the configurable product, we get an error because there is no value.

I'm not the only one, this question in StackeExchange is related to the same:
https://magento.stackexchange.com/questions/144954/variationmatrix-error-with-configurable-product-in-admin

[engcom-Delta]

@elfeffe I tried again and still cannot reproduce issue.
Manual testing scenario:

• Create configurable product with two dropdown attributes:
• • Color with values: red, blue
• • Test with values: 1, 2, 3
• Delete value of Color attribute for simple product that is associated with configurable product(e.g., conf1-red-2)
• Go to Edit page for configurable product in admin
• Refresh page.
• ✔️ Simple product(e.g., conf1-red-2) is not present in Configurations tab
• Click Save button
• ✔️ Configurable product is successfully saved with existing configurations

[elfeffe]

@engcom-Delta Well, I'm not sure about how to reproduce it.
But I had the offset error when I tried to edit, and as you see there is at least 2 different persons with the same problem in StackOverflow.
In any case, it seems to ve better to check if the array is empty in case this is not, and this is an extra control that will not bother anyone.

[engcom-Golf]

HI @elfeffe could you please sign in new CLA ?

[elfeffe]

Done! El lun., 7 oct. 2019 a las 9:31, Nazar Klovanych (<notifications@github.com>) escribió:

…

HI @elfeffe <https://github.com/elfeffe> could you please sign in new CLA ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24659?email_source=notifications&email_token=ABD7XQ66BRCFRGUATZMZAADQNLQWFA5CNFSM4IYLKRBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPI75Q#issuecomment-538873846>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABD7XQYCDZ77E6WI5ZLK7GTQNLQWFANCNFSM4IYLKRBA> .

[m2-assistant]

Hi @elfeffe, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[m2-assistant]

Hi @elfeffe, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-seis10]

This is still an issue for 2.3.5-p2