magento/magento2#24043: Better exception handling during cli commands.

[p-bystritsky]

Description (*)

This PR is updating https://github.com/magento/magento2ce/commit/9ffe7eb2d3e6fcbf18eb39b6b847e99b0550a028

Fixed Issues (if relevant)

1. Better exception handling during cli commands #24043: Better exception handling during cli commands.
2. Static Content Deploy in developer mode without force flag is broken in 2.3-develop #24678: Static Content Deploy in developer mode without force flag is broken in 2.3-develop

Manual testing scenarios (*)

1. Try to execute any incorrect console command through bin/magento
2. Correct exception message displayed in console.
3. Exception trace is logged in corresponding files.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5955 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[hostep]

@p-bystritsky : out of curiosity, will this also fix #24678 ?

[hostep]

I can confirm that applying this PR fixes #24678, nice!

@p-bystritsky: can you edit your post and add #24678 to the fixed issues list so it will get automatically marked as fixed when this PR gets merged? Thanks!

[hostep]

I do have one remark about only logging the trace to the system.log file: wouldn't it make sense to also log the exception message? Only logging the trace is a bit strange and provides little context about this entry in the log file and might leave people confused reviewing the log files as what that stacktrace is doing in there without an exception message itself, no?

[sidolov]

@hostep agree with you, @p-bystritsky could you take a look on it?

[p-bystritsky]

@hostep @sidolov updated

[hostep]

LGTM! Thanks!

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5955 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.