Resolved Issue #24785

[drpayyne]

Description

Resolved issue #24785

Added a JS method to handle the state of checked links in a downloadable product. The state is now managed and reflected in the label. Also added MFTF test to test changing of label.

• Unselect all is displayed only when all links are checked
• Select all is displayed otherwise

Fixed Issues

1. All selected values still display as Select all in downloadable product #24785: All selected values still display as Select all in downloadable product

Manual testing scenarios

1. Create a downloadable product in admin with downloadable links which can be purchased separately
2. Go to storefront, add the product to cart with both downloadable links checked
3. Open minicart and edit the product just added
4. Verify state of checked links with the conditions mentioned in the description

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[drpayyne]

@magento give me test instance

[magento-engcom-team]

Hi @drpayyne. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @drpayyne, here is your new Magento instance.
Admin access: https://pr-24800.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[VladimirZaets]

Hi @dryadav. Thanks for collaboration. Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.

[drpayyne]

@VladimirZaets Thank you. Although, I'm confused a bit. What test should I write? I have only added a method in a jQuery widget. 🤔

[VladimirZaets]

@drpayyne I think in this case we can write a functional test and check what is displayed, or at least JS unit test, that will check the new method that you created.

If you need documentation how to do it, or some additional information feels free to ask.

[drpayyne]

@VladimirZaets yes, can I have some references or documentations? I've written only PHPUnit tests. Thanks a lot!

[sidolov]

@drpayyne please, refer to Magento devdocs:
JavaScript unit testing with Jasmine
Introduction to the Magento Functional Testing Framework

[drpayyne]

@sidolov @VladimirZaets Hello, I added an MFTF test to test the changing of the label. Please review my code when you can. And thanks for helping me with the documentation reference.

Also, my Static Tests build is failing but says no errors in the Allure dashboard.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-6047 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.