Limit the php explode to 2 to prevent extra '=' sign content in the a…

[dhoang89]

Limit the PHP explode to 2 to prevent extra '=' sign content in the attribute value being exploded to more than 2 elements in the result array.

Description (*)

Fixed Issues (if relevant)

1. Magento 2.3: Import fails if configurable attribute has an equal sign in its value #25188: Import fails if configurable attribute has an equal sign in its value

Manual testing scenarios (*)

1. Install a new Magento base on branch 2.3-develop
2. Setup sample data following this Docs: https://devdocs.magento.com/guides/v2.3/install-gde/install/sample-data-after-clone.html
3. Go to Magento's backend. Then go to STORES > Attributes > Product > Search for Attribute Size. Scroll down to tab Properties then on the right side select 'Manage Swatch (Values of Your Attribute)' Modify the value, add '=' to any value, let say SX=SX
4. Reindex: bin/magento indexer:reindex
5. Go to System > Export > Products
6. Use the file you got from step 5 to import back. System > Import > Products
7. The error message showup

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @dhoang89. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Bravo]

Hello @dhoang89. Thank You for Your contribution. In order to further process Your PR, please cover it with the appropriate auto-tests.

[dhoang89]

Hi @engcom-Bravo, can you show me how to create an auto-test for my PR? Thank you.

[swnsma]

Hi, @dhoang89,
There is already tests available:
\Magento\ConfigurableImportExport\Model\Import\Product\Type\ConfigurableTest
Could you please add test-case to check the issue which you have fixed?

[engcom-Golf]

I will take care of test coverage

[engcom-Golf]

HI @swnsma changes covered by unit test, could you please review ?

[engcom-Golf]

@magento run all tests

[swnsma]

@magento run Unit Tests

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-6141 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @dhoang89, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.