Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated method usages of MessageManager #25281

Merged

Conversation

drpayyne
Copy link
Contributor

@drpayyne drpayyne commented Oct 25, 2019

Description

  • Fixed all deprecated method usages of MessageManager in Magento_Wishlist
  • Fixed appropriate PHPUnit tests

Manual testing scenarios

  • ONLY code modifications

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 25, 2019

Hi @drpayyne. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @drpayyne,
Could you review and fix failing tests/adjust your code?

@drpayyne
Copy link
Contributor Author

@ihor-sviziev I have fixed the failing MFTF and integration test. Replaced the with a better alternative and also fixed unnecessary code in the MFTF file.

@drpayyne drpayyne force-pushed the codefix/wishlist-01 branch 2 times, most recently from 01195c6 to e052a4a Compare October 25, 2019 16:45
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks for your contribution.

@ghost ghost assigned lbajsarowicz Oct 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6168 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 27, 2019
@drpayyne
Copy link
Contributor Author

@lbajsarowicz Thank you!

@engcom-Alfa engcom-Alfa self-assigned this Oct 29, 2019
@engcom-Alfa
Copy link
Contributor

Hi @drpayyne

During testing, we faced the issue

Problem: _404 Not found after updating Wish List

Steps to reproduce:

  1. Add simple product to Wishlist;
  2. From Wish List click on edit 🖊️ product button;
  3. Change, for example, the quantity of product;
  4. Click on "Update Wish List" button;

Actual Result: 404 not found error occurs
after

Probably, the problem is with HttpGetActionInterface in UpdateItemOptions class

@drpayyne Could you take a look?

Thanks!

@drpayyne
Copy link
Contributor Author

Hi @engcom-Alfa, thank you for your detailed comment. I've fixed it and sorry I missed that out. Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6168 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Nov 4, 2019

Hi @drpayyne, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants