New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed deprecated method usages of MessageManager #25281
Fixed deprecated method usages of MessageManager #25281
Conversation
Hi @drpayyne. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
f1f1dd0
to
654fbdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @drpayyne,
Could you review and fix failing tests/adjust your code?
app/code/Magento/Catalog/Test/Mftf/Test/AdminAddImageToWYSIWYGProductTest.xml
Outdated
Show resolved
Hide resolved
654fbdc
to
da16a9c
Compare
@ihor-sviziev I have fixed the failing MFTF and integration test. Replaced the with a better alternative and also fixed unnecessary code in the MFTF file. |
01195c6
to
e052a4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Thanks for your contribution.
Hi @lbajsarowicz, thank you for the review.
|
@lbajsarowicz Thank you! |
Hi @drpayyne During testing, we faced the issue Problem: _404 Not found after updating Wish List Steps to reproduce:
Actual Result: 404 not found error occurs Probably, the problem is with HttpGetActionInterface in UpdateItemOptions class @drpayyne Could you take a look? Thanks! |
e052a4a
to
139214e
Compare
Hi @engcom-Alfa, thank you for your detailed comment. I've fixed it and sorry I missed that out. Thank you! |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
Hi @drpayyne, thank you for your contribution! |
Description
Magento_Wishlist
Manual testing scenarios
Contribution checklist