Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lib wrapper for UUID validation. #25285

Merged
merged 6 commits into from
Feb 9, 2020
Merged

Add lib wrapper for UUID validation. #25285

merged 6 commits into from
Feb 9, 2020

Conversation

nikolaevas
Copy link
Contributor

Description (*)

Fix for the async-import project. Move third-party library dependency to core repository.

Fixed Issues (if relevant)

  1. https://github.com/magento/async-import/issues/148 Add lib wrapper for UUID generation/validation Fixed readability #148

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 25, 2019

Hi @nikolaevas. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned ihor-sviziev Oct 25, 2019
@ihor-sviziev
Copy link
Contributor

Hi @nikolaevas,
Your changes looks good.
Would be great to cover your changes with some tests. Will you be able to do that?

@nikolaevas nikolaevas closed this Oct 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2019

Hi @nikolaevas, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@nikolaevas nikolaevas reopened this Oct 27, 2019
@ghost ghost unassigned ihor-sviziev Oct 27, 2019
@ihor-sviziev ihor-sviziev self-assigned this Oct 27, 2019
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Oct 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6184 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Golf engcom-Golf self-assigned this Nov 1, 2019
@nuzil
Copy link
Contributor

nuzil commented Jan 8, 2020

@slavvka done

@slavvka
Copy link
Member

slavvka commented Jan 9, 2020

Hey @nuzil could you please fix the static tests?

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6184 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jan 15, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@slavvka slavvka self-assigned this Jan 15, 2020
@slavvka
Copy link
Member

slavvka commented Jan 16, 2020

BIC was approved https://jira.corp.magento.com/browse/MC-23065

magento-engcom-team pushed a commit that referenced this pull request Feb 9, 2020
@slavvka
ENGCOM-6184: Add lib wrapper for UUID validation. #25285
5877e54
@magento-engcom-team magento-engcom-team merged commit 8273d77 into magento:2.4-develop Feb 9, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2020

Hi @nikolaevas, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@naydav naydav Awaiting requested review from naydav

@buskamuza buskamuza Awaiting requested review from buskamuza

Assignees

@ihor-sviziev ihor-sviziev

@slavvka slavvka

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Composer Component: DataObject Progress: accept Release Line: 2.4 Squashtoberfest 2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@nikolaevas @ihor-sviziev @magento-engcom-team @slavvka @nuzil @engcom-Alfa @naydav @VladimirZaets @engcom-Golf