Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #20379 Calendar icon not aligned inside the textbox in Add Design Change page #25309

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

magudelo62
Copy link
Contributor

Description (*)

Changed class admin__scope-old to form-inline.

Fixed Issues (if relevant)

#20379: Issue title:calendar icon not aligned inside the textbox in Add Design Change page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2019

Hi @magudelo62. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Member

@rodrigowebjump rodrigowebjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @magudelo62 Thanks for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-6180 has been created to process this Pull Request
✳️ @rodrigowebjump, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@osrecio osrecio self-assigned this Oct 27, 2019
@osrecio osrecio added partners-contribution Pull Request is created by Magento Partner Partner: Interactiv4 Pull Request is created by partner Interactiv4 labels Oct 27, 2019
@engcom-Bravo engcom-Bravo self-assigned this Oct 29, 2019
@engcom-Bravo
Copy link
Contributor

Hello @rodrigowebjump. would You please add an appropriate label to the PR. Thank You.

@rodrigowebjump rodrigowebjump added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 29, 2019
@engcom-Bravo
Copy link
Contributor

Current PR is somewhat controversial. There is a similar PR #20389 now being closed. For the further processing please take into consideration the following comments 1, 2. As You may see the debates were started already in the issue (#20379) both PR are intended to fix. But nevertheless the issue remains confirmed. Therefore from my part I took and checked this PR. And the result is

✔️ QA Passed.

@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2019

Hi @magudelo62, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 12, 2019
@SeruyV
Copy link
Contributor

SeruyV commented Nov 18, 2019

@magudelo62, @engcom-Bravo your changes to the global file like admin-2columns-left.xml is very dangerous which could impact(and actually impact) on all Magento styles. This task needs to be reverted and implemented in another more specific way, as actually @sivaschenko reported here #20389 (review)
After pull request
role_after
visualafter
dropafter
Before pull request
visualbefore
dropdownbefore
roles_before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Theme Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants