Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue magento#25278:Incorrect @return type at getSourceModel in… #25333

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Fixed issue magento#25278:Incorrect @return type at getSourceModel in… #25333

merged 3 commits into from
Jan 17, 2020

Conversation

mkalakailo
Copy link
Contributor

@mkalakailo mkalakailo commented Oct 28, 2019 •
edited
Loading

This is fix for #25278 opened issue reported.

Description

The problem reported in #25278 is Incorrect @return type at getSourceModel method in Eav\Attribute.php class.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2019

Hi @mkalakailo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@mkalakailo mkalakailo closed this Oct 28, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2019

Hi @mkalakailo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mkalakailo mkalakailo deleted the #25278 branch October 28, 2019 15:04
@mkalakailo mkalakailo restored the #25278 branch October 28, 2019 15:12
@mkalakailo mkalakailo reopened this Oct 28, 2019
@mkalakailo mkalakailo closed this Oct 28, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2019

Hi @mkalakailo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mkalakailo mkalakailo reopened this Oct 28, 2019
@ghost ghost assigned VladimirZaets Oct 28, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6194 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

@mkalakailo thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@slavvka
Copy link
Member

slavvka commented Oct 31, 2019

@magento run all tests

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:17
@slavvka
Copy link
Member

slavvka commented Dec 6, 2019

This PR is currently under architecture review since SVC is failing

@slavvka slavvka self-assigned this Dec 17, 2019
@slavvka
Copy link
Member

slavvka commented Jan 6, 2020

Hey @mkalakailo please make suggested changes and we will be able to process your PR

@slavvka
Copy link
Member

slavvka commented Jan 9, 2020

@mkalakailo The architectural approval is granted. Please apply the change suggested so we could proceed with the delivery.
@engcom-Foxtrot Could you please assist with that?

@mkalakailo @slavvka
Update app/code/Magento/Catalog/Model/ResourceModel/Eav/Attribute.php
8f30b1e 
Co-Authored-By: Slava Mankivski <mankivsk@adobe.com>
@ghost ghost added the Progress: accept label Jan 9, 2020
@VladimirZaets VladimirZaets mentioned this pull request Jan 17, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jan 17, 2020
@VladimirZaets
ENGCOM-6194: Fixed issue #25278:Incorrect @return type at getSourceMo…
8f1413e 
…del in… #25333
@magento-engcom-team magento-engcom-team merged commit 8f30b1e into magento:2.4-develop Jan 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @mkalakailo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mkalakailo mkalakailo deleted the #25278 branch January 21, 2020 15:25
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka left review comments

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@VladimirZaets VladimirZaets

@slavvka slavvka

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Progress: accept Release Line: 2.4 Squashtoberfest 2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mkalakailo @magento-engcom-team @slavvka @VladimirZaets @ihor-sviziev @sidolov @michael-elogic