Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 24400 #25365

Closed
wants to merge 6 commits into from
Closed

Issue 24400 #25365

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 30, 2019

Description (*)

Fixed Issues (if relevant)

  1. Issues Found on Grid Multi-Select Column #24400:Issue Found on Grid Multi-Select Column

Manual testing scenarios (*)

  1. Open any grid having some records.
  2. Click on Header Checkbox to select all record on current page. https://prnt.sc/p09pr0
  3. Now unselect some record, on click particular row: https://prnt.sc/p09pya
  4. Again click on Header Checkbox, here is the issue.
  5. Now you will see all records are unselected but header checkbox is selected. https://prnt.sc/p09qh6

Expected Result is :
https://prnt.sc/p09qof

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ghost ghost requested a review from DrewML as a code owner October 30, 2019 10:27
@m2-assistant
Copy link

m2-assistant bot commented Oct 30, 2019

Hi @prabhatrawat-webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost
Copy link
Author

ghost commented Oct 30, 2019

@DrewML Can you please let me know why the static test failed.

@slavvka
Copy link
Member

slavvka commented Oct 31, 2019

@magento run all tests

ptylek
ptylek suggested changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@ptylek ptylek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prabhatrawat-webkul! Thank you for your contribution. Changes requested.

app/code/Magento/Ui/view/base/web/js/grid/columns/multiselect.js

if (this.isPageSelected() && selected !== total) {
return this.selectPage();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyword return at line 244 should have an empty line above it.

@ghost ghost assigned ptylek Nov 22, 2019
@ghost ghost requested a review from ptylek November 23, 2019 20:36
ptylek
ptylek suggested changes Nov 24, 2019
View reviewed changes
app/code/Magento/Ui/view/base/web/js/grid/columns/multiselect.js

if (total < selected && total > -1) {
total = selected;
}
if (this.excludeMode()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyword if should have an empty line above it at line 325.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:16
@VladimirZaets VladimirZaets self-assigned this Dec 9, 2019
@VladimirZaets
Copy link
Contributor

@prabhatrawat-webkul, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@m2-assistant
Copy link

m2-assistant bot commented Dec 9, 2019

Hi @prabhatrawat-webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrewML DrewML Awaiting requested review from DrewML

Assignees

@VladimirZaets VladimirZaets

@ptylek ptylek

Labels
Area: Frontend Component: Ui Progress: needs update Release Line: 2.4 Squashtoberfest 2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@slavvka @VladimirZaets @ptylek @sidolov @magento-engcom-team @prabhatrawat