Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue #22909 #25377

Closed

Conversation

Shubham0492
Copy link

Description (*)

When the DOMContentLoaded event is fired on the document.

Fixed Issues (if relevant)

  1. requirejs/domReady.js can severely delay rendering of content #22909: requirejs/domReady.js can severely delay rendering of content

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 30, 2019

Hi @Shubham-Webkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@krzksz
Copy link
Contributor

krzksz commented Nov 7, 2019

I'm closing it as a duplicate of #23313, since this PR contains exactly the same code changes. If you feel that there are some other adjustments needed, please comment there or reopen this PR.

@krzksz krzksz closed this Nov 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2019

Hi @Shubham-Webkul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants