Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue #20472 so that controlled columns price type values in catalog grid will also display price in formatted way #25402

Closed

Conversation

webkul-ratnesh
Copy link
Contributor

@webkul-ratnesh webkul-ratnesh commented Oct 31, 2019

Description (*)

Fixed Issues (if relevant)

  1. Special Price shown without currency symbol in magento backoffice #20472: Special Price shown without currency symbol in magento backoffice

Manual testing scenarios (*)

  1. Goto Catalog-> Product in admin panel.
  2. Click on the columns menu in top right hand side, and select cost and special price column to display in grid.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…es in catalog grid will also display price in formatted way
@m2-assistant
Copy link

m2-assistant bot commented Oct 31, 2019

Hi @webkul-ratnesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@krzksz
Copy link
Contributor

krzksz commented Dec 8, 2019

Hey @webkul-ratnesh, please take a look at failing tests.

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @webkul-ratnesh, thank you for your contribution, but I don't think that these columns are expected to be visible by default in product listing.
Could you please refactor this solution in a proper way?

See #22739.

@ghost ghost assigned eduard13 Feb 17, 2020
@eduard13
Copy link
Contributor

eduard13 commented Mar 3, 2020

Hello @webkul-ratnesh, I'm closing this PR now due to inactivity.
Feel free to reopen and update if you wish to continue.
Thank you!

@eduard13 eduard13 closed this Mar 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 3, 2020

Hi @webkul-ratnesh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants