Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin > Advanced Report > Changing link #25412

Merged
merged 7 commits into from
Oct 7, 2020
Merged

Admin > Advanced Report > Changing link #25412

merged 7 commits into from
Oct 7, 2020

Conversation

rafaelstz
Copy link
Member

@rafaelstz rafaelstz commented Oct 31, 2019 •
edited by sdzhepa
Loading

Description (*)

I added a verification if the token exists (the BI is configured) then go to the panel, if it is not configured, go to the documentation about it in the DevDocs.

Screen Shot 2019-10-31 at 12 53 44 PM

Fixed Issues

  1. fixes Magento_Analytics wrong link #25411: Magento_Analytics wrong link

Manual testing scenarios (*)

  1. Access the admin panel
  2. Click into the Advanced Report button.

Screen Shot 2019-10-31 at 12 52 19 PM

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 31, 2019

Hi @rafaelstz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rafaelstz rafaelstz mentioned this pull request Oct 31, 2019
Closed
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:16
@krzksz
Copy link
Contributor

krzksz commented Dec 8, 2019

Hey @rafaelstz, please take a look at failing tests.

@magento-engcom-team magento-engcom-team added this to Pending Review in Pull Requests Dashboard Mar 24, 2020
@ihor-sviziev ihor-sviziev self-assigned this Sep 11, 2020
@ihor-sviziev ihor-sviziev moved this from Pending Review to Review in Progress in Pull Requests Dashboard Sep 11, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

ihor-sviziev
ihor-sviziev requested changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rafaelstz,
Could you review and fix failing tests?

app/code/Magento/Analytics/etc/config.xml Outdated Show resolved Hide resolved
@ghost ghost moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Sep 11, 2020
@engcom-Charlie
Copy link
Contributor

Hi @rafaelstz, please look at the requested changes #25412 (review) and review failed tests. Otherwise, we can't proceed with your PR.
Thank you.

ihor-sviziev
ihor-sviziev requested changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engcom-Charlie tests still failing. Could you double check it?

@ghost ghost moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Oct 5, 2020
@engcom-Charlie engcom-Charlie moved this from Changes Requested to Pending Review in Pull Requests Dashboard Oct 6, 2020
@ghost ghost moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Oct 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8314 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Bravo engcom-Bravo self-assigned this Oct 6, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

Manual testing scenario

  1. Open Admin Panel
  2. Click Go to Advanced Reporting

Before applying changes provided in this PR, admin was redirected to https://advancedreporting.rjmetrics.com/report
redirect

After switching to the PR, devdocs, Advanced Reporting section
Advanced reporting

@engcom-Bravo engcom-Bravo added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Oct 7, 2020
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Oct 7, 2020
@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Oct 7, 2020
@engcom-Bravo engcom-Bravo moved this from Extended Testing (optional) to Merge in Progress in Pull Requests Dashboard Oct 7, 2020
@engcom-Bravo engcom-Bravo added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Oct 7, 2020
magento-engcom-team pushed a commit that referenced this pull request Oct 7, 2020
@gabrieldagama
ENGCOM-8314: Admin > Advanced Report > Changing link #25412
663df29
@magento-engcom-team magento-engcom-team merged commit da94864 into magento:2.4-develop Oct 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2020

Hi @rafaelstz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@buskamuza buskamuza Awaiting requested review from buskamuza

@tariqjawed83 tariqjawed83 Awaiting requested review from tariqjawed83

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Bravo engcom-Bravo

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Analytics Partner: Le Site partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Squashtoberfest 2019
Projects
Pull Requests Dashboard
  
Recently Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Magento_Analytics wrong link
7 participants
@rafaelstz @krzksz @ihor-sviziev @engcom-Charlie @magento-engcom-team @engcom-Bravo @sidolov