Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore checkboxes alignment in admin data grids #25443

Merged

Conversation

krzksz
Copy link
Contributor

@krzksz krzksz commented Nov 2, 2019

Description (*)

This PR fixes checkboxes alignment in data grids in Magento admin panel. Without it, they are either not fully centred (Firefox, Safari, older Chrome) or totally shifted to the left (newest Chrome).

Fixed Issues (if relevant)

  1. Magento 2.3.3 : Under Cache Management section, cache type checkboxes are not aligned  #25429: Magento 2.3.3 : Under Cache Management section, cache type checkboxes are not aligned

Manual testing scenarios (*)

  1. Open admin panel and check data grids, e.g. cache management, index management, products in category etc.
  2. Checkboxes should be centred within first column on the left.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 2, 2019

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 2, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6227 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2019

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants