Fix issue #22240: Running cron jobs fails if database name is too long

[vpashovski]

Description (*)

Create short name for Database Lock name.
Use same logic to generate name as Foreign keys if name is longer than 64 characters.

Fixed Issues (if relevant)

1. Running cron jobs fails if database name is too long #22240: Running cron jobs fails if database name is too long

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @vpashovski. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[PascalBrouwers]

🙏

[engcom-Alfa]

Hi @vpashovski

I've checked PR changes and looks like all works correctly.
But we do not fully understand why to leave the check
if (strlen($name) > 64) { throw new InputException(new Phrase('Lock name too long: %1...', [substr($name, 0, 64)])); } if the $name value cannot be greater then 64 symbols.

Did I misunderstand something?

@vpashovski @pmclain Could you take a look?

Thanks!

[vpashovski]

Hi @engcom-Alfa

I think you are right - the check is not necessary anymore. I will remove it and commit.

[PascalBrouwers]

Looks good, go go go merge! :)

[magento-engcom-team]

Hi @pmclain, thank you for the review.
ENGCOM-6253 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Before:

After:

[m2-assistant]

Hi @vpashovski, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.