Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes hardcoded references to country selector component #25541

Merged

Conversation

krzksz
Copy link
Contributor

@krzksz krzksz commented Nov 9, 2019

Description (*)

This change is aimed to fix #22416 and loosen up the coupling between shipping and country selector components in case they are moved around in the hierarchy. Applying this patch makes it possible to at least change their paths through component configuration.

Additionally, region and postcode components were refactored a bit to simplify how validation logic is written.

Fixed Issues (if relevant)

  1. Coupling beetwen Magento_Checkout::js/view/shipping.js:validateShippingInformation() and layout definition or view.  #22416: Coupling beetwen Magento_Checkout::js/view/shipping.js:validateShippingInformation() and layout definition or view.

Manual testing scenarios (*)

  1. Go to the checkout.
  2. Switch through different countries through select input.
  3. Make sure that region and postcode fields retain their validation for selected countries.

Questions or comments

This chain is meant purely to improve developer experience when adjusting the checkout structure and shouldn't change any of the business logic.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@krzksz krzksz requested a review from DrewML as a code owner November 9, 2019 11:57
@m2-assistant
Copy link

m2-assistant bot commented Nov 9, 2019

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Copy link
Contributor

@VladimirZaets VladimirZaets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krzksz. Thanks for collaboration. Please take a look at failed tests.

@ghost ghost assigned VladimirZaets Nov 11, 2019
@krzksz krzksz force-pushed the checkout-country-options branch 4 times, most recently from 6966f65 to ca110c5 Compare November 16, 2019 22:18
@krzksz
Copy link
Contributor Author

krzksz commented Nov 18, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krzksz. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, here is your Magento instance.
Admin access: https://i-25541-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@VladimirZaets VladimirZaets added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Nov 25, 2019
@VladimirZaets
Copy link
Contributor

@magento run all tests

@krzksz krzksz force-pushed the checkout-country-options branch 7 times, most recently from af34f26 to cc1f7b8 Compare December 1, 2019 18:40
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6389 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Dec 8, 2019

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants