M2C-22090 Translate Wishlist and Compare label in template

[ptylek]

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/372

Description (*)

I checked this issue and right now these labels are created in backend when someone adds a product to Wishlist or Compare list. So if a product is added on English Store the label that is stored is 'item' or 'items'. Once a customer switches to German Store, the label is still stored as 'item' or 'items'. In order to update the label, the customer must add a new product (remove/update) to Wishlist or Compare list.

In my opinion keeping this label in backend is not the best idea. There might be a possibility to update customerData once the store has been changed but that would require backend resources, also we have translation options available both in knockout and phtml templates.

As the counter for Wishlist and Compare list is rendered with knockout, I tried to add span elements with data-bind="i18n: '...'" however I noticed that that didn't solve the issue while switching the store. I'm not quite sure but maybe the template is cached then. Using knockout's translate function doesn't work in phtml templates.

In the end I decided to check counter value with knockout and render different translation strings using Magento translation system in phtml templates.

Fixed Issues (if relevant)

1. Wrong product label when changing store view #24290: Wrong product label when changing store view

Manual testing scenarios (*)

1. Create an account
2. Add a product to Wish List and Compare List
3. Switch store
4. Check if counter labels (e.g. '1 item', '4 items') are being translated properly

Please make sure to have two stores with different locale and translation packages installed.

Questions or comments

I might need to update tests and I will do so.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ptylek]

I fixed Static tests however I am not sure how to work on Semantic Version Checker test. Could anyone advise?

[ptylek]

Helpers reworked using viewModel

[magento-engcom-team]

Hi @krzksz, thank you for the review.
ENGCOM-6555 has been created to process this Pull Request

[ptylek]

@slavvka I added your suggestion in order to fix PAT scenario that was discussed some time ago. Let's see if anything needs adjusting after tests are completed.

[ptylek]

@magento run all tests

[gabrieldagama]

@magento run all tests

[gabrieldagama]

@magento run all tests

[ptylek]

@magento run Functional Tests CE, Functional Tests EE

[ptylek]

@magento run all tests

[ptylek]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[ptylek]

@magento run Functional Tests CE, Functional Tests EE

[gabrieldagama]

@magento run all tests

[gabrieldagama]

@magento run all tests

[ptylek]

@magento run Database Compare

[ptylek]

@magento run all tests

[magento-automated-testing]

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.