Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set correct pram like in BlockRepository implementation #25640

Merged
merged 1 commit into from
Jan 8, 2020
Merged

set correct pram like in BlockRepository implementation #25640

merged 1 commit into from
Jan 8, 2020

Conversation

torhoehn
Copy link
Contributor

Description (*)

Parameter in interface was different than in the implementation.
See:

  1. https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Cms/Model/BlockRepository.php#L129
  2. https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Cms/Model/BlockRepository.php#L186

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 18, 2019

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6301 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Nov 20, 2019
@engcom-Alfa engcom-Alfa added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 20, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 20, 2019
@torhoehn torhoehn closed this Nov 28, 2019
@torhoehn torhoehn deleted the feature/block-repository branch November 28, 2019 10:19
@m2-assistant
Copy link

m2-assistant bot commented Nov 28, 2019

Hi @torhoehn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@torhoehn torhoehn restored the feature/block-repository branch November 28, 2019 10:20
@sivaschenko sivaschenko reopened this Nov 28, 2019
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:12
@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @torhoehn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@torhoehn torhoehn deleted the feature/block-repository branch January 24, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Cms Partner: Basecom partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants