Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#25540: Products are not displaying infront end after updating product via importing CSV. #25664

Merged
merged 5 commits into from
Mar 25, 2020

Conversation

p-bystritsky
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Products are not displaying infront end after updating product via importing CSV. #25540: Products are not displaying infront end after updating product via importing CSV.

Manual testing scenarios (*)

  1. Create Simple product.
  2. Create Bundle product, assign Simple to it.
  3. Open Storefront, make sure Bundle product is visible and in stock.
  4. Go to System -> Data Transfer -> Export and export products.
  5. Go to System -> Data Transfer -> Import and import products.
  6. Do reindex and flush cache.
  7. Open Storefront, make sure Bundle product is visible and in stock.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost
Copy link

ghost commented Nov 20, 2019

@p-bystritsky unfortunately, only members of the maintainers team are allowed to add progress related labels to the pull request

@engcom-Echo
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-bystritsky please address build failures. Thanks.

@lenaorobei
Copy link
Contributor

@p-bystritsky are you still up to finishing it?

@p-bystritsky p-bystritsky removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Progress: needs update labels Mar 18, 2020
@ghost
Copy link

ghost commented Mar 18, 2020

@p-bystritsky unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@p-bystritsky
Copy link
Contributor Author

@lenaorobei done.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7145 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@lenaorobei lenaorobei added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Mar 19, 2020
@engcom-Alfa engcom-Alfa self-assigned this Mar 20, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@m2-assistant
Copy link

m2-assistant bot commented Mar 25, 2020

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost moved this from Merge in Progress to Recently Merged in Pull Requests Dashboard Mar 25, 2020
@magento-engcom-team magento-engcom-team removed this from Recently Merged in Pull Requests Dashboard Apr 25, 2020
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants