Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experius 2.3 patch catalog flat #25734

Conversation

lewisvoncken
Copy link
Contributor

Description (*)

When the index type product flat is set to 'On Schedule' disabled products were not removed from the table until a full reindex.

Manual testing scenarios (*)

  1. Set the Flat Product to On Schedule
  2. Disable the Test Product
  3. Run the indexer_update_all_views cron with magerun2 or make sure the cron is running
  4. As a result the product is still in the flat table
  5. Apply changes
  6. Enable the Test Product
  7. Disable the Test Product
  8. Run the indexer_update_all_views cron with magerun2 or make sure the cron is running
  9. As a result the product is removed from the flat table

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2019

Hi @lewisvoncken. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:12
@ihor-sviziev ihor-sviziev self-assigned this Feb 17, 2020
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewisvoncken,
Your changes looks good to me. Could you cover your changes with tests and fix static test failures?

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Feb 26, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Integration Tests

@engcom-Charlie engcom-Charlie self-assigned this Feb 27, 2020
@engcom-Charlie
Copy link
Contributor

Hi @ihor-sviziev, I'll take care of the test coverage.

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Mar 3, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7019 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @lewisvoncken, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants