Magento#25739: fixed issue "grunt clean does not clean generated folder"

[andrewbess]

Description (*)

Fixed issue when the command grunt clean didn't clean the directory "generated/"

Fixed Issues (if relevant)

1. grunt clean does not clean generated folder #25739: grunt clean does not clean generated folder

Manual testing scenarios (*)

1. Install magento 2.3.x
2. Install and set up Grunt following to devdocs documentation
3. Enable "Production" mode
4. Use command grunt clean after command bin/magento setup:di:compile
5. Expected result

• the directory generated/code should be empty
• the directory generated/metadata should be empty

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @andrewbess. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[Stepa4man]

Hi @andrewbess
Thanks for your contribution

[magento-engcom-team]

Hi @Stepa4man, thank you for the review.
ENGCOM-6344 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

Hi @andrewbess .
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.
Thanks!

[andrewbess]

Hi @andrewbess .
Due to Magento Definition of Done all code must be covered by tests. Please cover your fix by automated tests.
Thanks!

Hello @engcom-Alfa
Ok.
I don't see, that "grunt" is covered tests at this moment, but I can try to do it.
Maybe should it have label Auto-Tests: Not Required?

[rogyar]

Hi @Stepa4man.

I'm not sure about an optimistic way to cover this particular change with an autotest somehow. In some cases, we can create an integration test that will test files generation and similar operations. But in this case, we need to test a 3rd party application that doesn't go with Magento out of the box. So, we need to introduce a new flow for the CI system that will install nodeJs + grunt and test the result of grunt clean invocation.
So, I would recommend Auto Test: Not Required label here. Or, perhaps you have some thoughts on how we can handle the autotests coverage.

Thank you.

[Stepa4man]

Hi @Stepa4man.

I'm not sure about an optimistic way to cover this particular change with an autotest somehow. In some cases, we can create an integration test that will test files generation and similar operations. But in this case, we need to test a 3rd party application that doesn't go with Magento out of the box. So, we need to introduce a new flow for the CI system that will install nodeJs + grunt and test the result of grunt clean invocation.
So, I would recommend Auto Test: Not Required label here. Or, perhaps you have some thoughts on how we can handle the autotests coverage.

Thank you.

@rogyar Thanks for the recommendation. I have changed the label.

[engcom-Alfa]

✔️ QA Passed

Actual Result: (with fix)

[m2-assistant]

Hi @andrewbess, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[tuna2smc]

just curious why we need clean generated folder with grunt. From frontend works i think we don't need touch to generated folder

[tuna2smc]

From backend works. I think we can use command rm -r generated/* then re-run di compilation