Drop indexer changelog tables on mview unsubscribe

[fredden]

Description (*)

This pull request will remove the unused changelog tables when changing an index from 'update on schedule' to 'update on save'.

From what I can tell, this was the case before 6ae3c48 was merged. I have tried to avoid any regressions here by marking the index as invalid when dropping the table, to catch any entries which might have otherwise been missed. It seems that 6ae3c48 only protects missed changelog entries if the index is switched back to 'update on schedule'. The change introduced here solves that problem by always performing a full index (via normal minutely cron).

Fixed Issues

• Fixes [Investigation] Indexers stuck after redeploy ece-tools#729
• resolves [Issue] Drop indexer changelog tables on mview unsubscribe #29789: Drop indexer changelog tables on mview unsubscribe

Manual testing scenarios (*)

1. Set indexes to 'update on schedule'
2. Make a change which will trigger an entry in the changelog table (eg, update product name in admin)
3. Wait for normal minutely cron to run index
4. Observe data in version_id column in mview_state table.
5. Change indexes to 'update on save'
6. Observe data in version_id column in mview_state table.
7. Note that all changed indexes are now 'invalid' and will be fully indexed via normal minutely cron.

Questions or comments

I am not confident that I have fully covered all changes here in unit tests. Please may I have some advice as to how I might need to adjust the unit tests to ensure no regressions.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Drop indexer changelog tables on mview unsubscribe #29789: Drop indexer changelog tables on mview unsubscribe

[m2-assistant]

Hi @fredden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

Hi @fredden,
Could you review and fix failing tests?

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Charlie]

It seems that bot moved this PR to review hence moving it back to Pending Approval.

[fredden]

@engcom-Charlie, please can you provide an update on this pull request.

[engcom-Echo]

@magento run all tests

[engcom-Delta]

@magento run all tests

[engcom-Delta]

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Manual testing scenario:

1.Login to magento admin
2.Go to System - Index Management
3.Select All indexers from Mass Actions and select Update by Schedule from Actions, click submit.
4.The indexers Status is updated, run php bin/magento indexer:status
5.Go to Catalog - Products and Edit an existing Product Name. Save product
6.Run php bin/magento indexer:status
7.Wait for normal minutely cron to run index or run php bin/magento cron:run
8.Check the indexer status php bin/magento indexer:status
9.Go to System - Index Management
10.Select All indexers from Mass Actions and select Update on save from Actions, click Submit
11.Check the indexers Status, run php bin/magento indexer:status

Before: ✖️ 

After: ✔️  

Builds are failed. Hence, moving this PR to Extended Testing.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run WebAPI Tests,Integration Tests,Functional Tests EE ,Functional Tests CE,Functional Tests B2B

[engcom-Echo]

Functional Tests CE,Functional Tests EE,Functional Tests B2B failure are different on last two run on same commit.

Functional Tests CE
Run1

Run2

Functional Tests EE
Run1

Run2

Functional Test B2B contains known failure.
Below are the JIRA for it.
ACQE-6364
ACQE-6363
ACQE-6346
ACQE-6366

Hence moving it to merge in progress.