Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Removed spacing in submenu on hover desktop] #25973

Conversation

hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Dec 10, 2019

Description (*)

No space required in sub-menu top and bottom.

Fixed Issues (if relevant)

  1. Not required spacing in submenu on hover desktop #25972: Removed spacing in submenu on hover desktop

Manual testing scenarios (*)

Go to the Home page and hover menu.

Expected result

  1. No space required in sub menu top and bottom .
    expected

Actual result

  1. Space in sub menu top and bottom .
    actual

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Dec 10, 2019
@hitesh-wagento hitesh-wagento changed the title [Removed spacing in submenu on hover desktop #25972] [Removed spacing in submenu on hover desktop] Dec 10, 2019
@miguelbalparda miguelbalparda self-assigned this Dec 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6447 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 11, 2019
@engcom-Alfa engcom-Alfa self-assigned this Dec 12, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2019

Hi @hitesh-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Lib/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants