Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpdoc fix return type #25975

Merged
merged 2 commits into from Dec 16, 2019
Merged

phpdoc fix return type #25975

merged 2 commits into from Dec 16, 2019

Conversation

maslii
Copy link
Member

@maslii maslii commented Dec 10, 2019

Description (*)
Fixed phpdoc comment return type in the Customer Account CreatePost controller.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2019

Hi @maslii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@okorshenko
Copy link
Contributor

Hi @maslii
Could you please sign Adobe CLA so that we can proceed with PR acceptance

@maslii
Copy link
Member Author

maslii commented Dec 11, 2019

Signed

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, thank you for the review.
ENGCOM-6457 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 45751d3 into magento:2.4-develop Dec 16, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2019

Hi @maslii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants