-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAGETWO-95866 Add horizontal scroll if elements extend menu's width #26034
MAGETWO-95866 Add horizontal scroll if elements extend menu's width #26034
Conversation
Hi @ptylek. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @krzksz, thank you for the review.
|
It's purely visual change, tests not required. |
Hi @ptylek, thank you for your contribution! |
Description (*)
If a user install extension which adds multiple columns in any submenu (e.g. Marketing tab), then he wouldn't be able to see those which extend submenu's width.
As this container has position: absolute, we are not able to use flex as its children does not participate in flex layout (https://www.w3.org/TR/css-flexbox-1/#abspos-items).
The other option was to use grid, however it is not widely supported in browsers such as IE11 (https://caniuse.com/#feat=css-grid).
Last but not least, in order to provide access for the user to those additional extension's columns, we can add a horizontal scroll which only appears in that case.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Comment: In order to have scroll below container, I dropped container's min-height (using 100%) in favor of submenu's min-height as a variable.
Screenshots:
![Screenshot 2019-12-13 at 19 43 28](https://user-images.githubusercontent.com/34317830/70823729-eb8d3080-1de0-11ea-8a01-cf7c929d67a0.png)
![Screenshot 2019-12-13 at 19 43 05](https://user-images.githubusercontent.com/34317830/70823762-f942b600-1de0-11ea-9a25-6354a6d08b5b.png)
Contribution checklist (*)