Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGETWO-95866 Add horizontal scroll if elements extend menu's width #26034

Conversation

ptylek
Copy link
Contributor

@ptylek ptylek commented Dec 13, 2019

Description (*)

If a user install extension which adds multiple columns in any submenu (e.g. Marketing tab), then he wouldn't be able to see those which extend submenu's width.
As this container has position: absolute, we are not able to use flex as its children does not participate in flex layout (https://www.w3.org/TR/css-flexbox-1/#abspos-items).
The other option was to use grid, however it is not widely supported in browsers such as IE11 (https://caniuse.com/#feat=css-grid).
Last but not least, in order to provide access for the user to those additional extension's columns, we can add a horizontal scroll which only appears in that case.

Fixed Issues (if relevant)

  1. Left Side Back End Menu Design fix #18687: Left Side Back End Menu Design fix

Manual testing scenarios (*)

  1. Install the multiple extension which is creating sub menu in Marketing tab
  2. Access the admin side to see how it looks like

Questions or comments

Comment: In order to have scroll below container, I dropped container's min-height (using 100%) in favor of submenu's min-height as a variable.

Screenshots:
Screenshot 2019-12-13 at 19 43 28
Screenshot 2019-12-13 at 19 43 05

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 13, 2019

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: creativestyle partners-contribution Pull Request is created by Magento Partner labels Dec 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6464 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@krzksz
Copy link
Contributor

krzksz commented Dec 16, 2019

It's purely visual change, tests not required.

@krzksz krzksz added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 16, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Actual Result:
after2

@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2019

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants