Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with reorder when disabled reorder setting from admin issue25130 #26051

Merged
merged 5 commits into from
Jan 17, 2020
Merged

Issue with reorder when disabled reorder setting from admin issue25130 #26051

merged 5 commits into from
Jan 17, 2020

Conversation

edenduong
Copy link
Contributor

Description (*)

  1. Resolve Issue with reorder when disabled reorder setting from admin #25130: Issue with reorder when disabled reorder setting from admin

Fixed Issues (if relevant)

  1. Issue with reorder when disabled reorder setting from admin #25130: Issue with reorder when disabled reorder setting from admin

Manual testing scenarios (*)

  1. Place order from frontend as a customer or guest
  2. Open order view page from frontend
  3. Login into admin panel
  4. Disable reorder option from admin. Navigate to Store -> Configuration-> Sales -> Reorder -> Allow Order and set this to NO
  5. Go to opened order view page and click on reorder.

Selection_011
Selection_009

Expected result (*)

  1. Reorder should be disabled and there should be some error message Reorder is not available.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 15, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned lbajsarowicz Dec 15, 2019
@edenduong
Copy link
Contributor Author

@lbajsarowicz: I have changed the source code. Please check it again. Thanks :)

@edenduong
Copy link
Contributor Author

Could you please take a look? Thanks @lbajsarowicz

lbajsarowicz
lbajsarowicz approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6492 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Dec 17, 2019
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Dec 17, 2019
engcom-Alfa
engcom-Alfa requested changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edenduong See my comment

@edenduong
Copy link
Contributor Author

edenduong commented Dec 18, 2019 •
edited
Loading

@edenduong See my comment

Thank you. Please check it again. @lbajsarowicz @engcom-Alfa

@engcom-Alfa
Copy link
Contributor

@lbajsarowicz Could you review the last commit?

Thanks!

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Golf engcom-Golf self-assigned this Dec 19, 2019
@slavvka
Copy link
Member

slavvka commented Jan 9, 2020

MHI failure (Global state usage defined at current file: Magento\Framework\Registry in Magento/Sales/Test/Unit/Controller/Guest/ReorderTest.php) is approved since it is mock for a dependency in the class

@VladimirZaets VladimirZaets mentioned this pull request Jan 17, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jan 17, 2020
@VladimirZaets
ENGCOM-6492: Issue with reorder when disabled reorder setting from ad…
a51aeeb 
…min issue25130 #26051
@magento-engcom-team magento-engcom-team merged commit c4baf83 into magento:2.4-develop Jan 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@joni-jones joni-jones Awaiting requested review from joni-jones

@engcom-Alfa engcom-Alfa Awaiting requested review from engcom-Alfa

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Alfa engcom-Alfa

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Sales Progress: accept Release Line: 2.4 tech-partners-contribution Technology Partner: Magestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with reorder when disabled reorder setting from admin
6 participants
@edenduong @magento-engcom-team @engcom-Alfa @slavvka @lbajsarowicz @engcom-Golf