New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GiftMessage] Cover Observer SalesEventOrderItemToQuoteItemObserver by Unit Test #26082

Merged

magento-engcom-team merged 2 commits into magento:2.4-develop from edenduong:2.4-testcover/cover_order_item_to_quote

Dec 19, 2019

Contributor

edenduong commented Dec 17, 2019

Description (*)

Increase Test Coverage by Cover class Magento\GiftMessage\Observer\SalesEventOrderItemToQuoteItemObserver

Fixed Issues (if relevant)

Manual testing scenarios (*)

vendor/bin/phpunit app/code/Magento/GiftMessage/Test/Unit/Observer/SalesEventOrderItemToQuoteItemObserverTest.php

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)


          [GiftMessage] Cover Observer SalesEventOrderItemToQuoteItemObserver b…

8201ea2

…y Unit Test

edenduong requested a review from paliarush as a code owner

December 17, 2019 15:17

m2-assistant bot commented Dec 17, 2019

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

magento-engcom-team added tech-partners-contribution Technology Partner: Magestore labels

lbajsarowicz suggested changes

View reviewed changes

Contributor

lbajsarowicz left a comment

I'm really glad with the progress that you've done so far.
Actually - Unit Tests should not contain extra conditional logic.

app/code/Magento/GiftMessage/Test/Unit/Observer/SalesEventOrderItemToQuoteItemObserverTest.php Outdated Show resolved Hide resolved

app/code/Magento/GiftMessage/Test/Unit/Observer/SalesEventOrderItemToQuoteItemObserverTest.php Outdated Show resolved Hide resolved

app/code/Magento/GiftMessage/Test/Unit/Observer/SalesEventOrderItemToQuoteItemObserverTest.php Outdated Show resolved Hide resolved

ghost assigned lbajsarowicz

ghost added the Progress: needs update label


          Refactor code to pass review

85036fa

Contributor Author

edenduong commented Dec 18, 2019

Hi @lbajsarowicz : It is ok now. Thank you for your feedback. Please check it again.

lbajsarowicz approved these changes

View reviewed changes

Contributor

lbajsarowicz left a comment

Small things that you may change, but it's not crucial.
Once again great contribution. Thank you!

app/code/Magento/GiftMessage/Test/Unit/Observer/SalesEventOrderItemToQuoteItemObserverTest.php

Comment on lines +112 to +122

+                      $this->eventMock->expects($this->atLeastOnce())
+                          ->method('getOrderItem')
+                          ->willReturn($this->orderItemMock);
+                      $this->orderItemMock->expects($this->atLeastOnce())
+                          ->method('getOrder')
+                          ->willReturn($this->orderMock);
+                      $this->observerMock->expects($this->atLeastOnce())
+                          ->method('getEvent')
+                          ->willReturn($this->eventMock);

Contributor

lbajsarowicz Dec 18, 2019

For these three, I'd avoid ->expects part, as someone could want to test the scenario where code does not reach the getOrderItem or getOrder point.

app/code/Magento/GiftMessage/Test/Unit/Observer/SalesEventOrderItemToQuoteItemObserverTest.php

+                  /**
+                   * Test when the order is reorder
+                   */
+                  public function testReorder()

Contributor

lbajsarowicz Dec 18, 2019

You can do it even more explanatory: testReorderDoesNotCheckIsMessageAllowed

app/code/Magento/GiftMessage/Test/Unit/Observer/SalesEventOrderItemToQuoteItemObserverTest.php

+                  /**
+                   * Test when the order is new reorder and gift message is not allowed
+                   */
+                  public function testNewOrderWhenGiftMessageIsNotAllowed()

Contributor

lbajsarowicz Dec 18, 2019

Also: testNewOrderWhenGiftMessageIsNotAllowedDoesNotGetQuoteItem to explain what actually is going on inside (It's very useful when you're browsing ouput of phpunit execution)

app/code/Magento/GiftMessage/Test/Unit/Observer/SalesEventOrderItemToQuoteItemObserverTest.php

+                  /**
+                   * Test when the order is new reorder and gift message is allowed
+                   */
+                  public function testNewOrderWhenGiftMessageIsAllowed()

Contributor

lbajsarowicz Dec 18, 2019

testNewOrderWhenGiftMessageIsAllowedCreatesNewMessage

ghost added Progress: ready for testing and removed Progress: needs update labels

magento-engcom-team added Release Line: 2.4 Component: GiftMessage labels

Contributor

magento-engcom-team commented Dec 18, 2019

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6496 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Charlie self-assigned this

ghost added Progress: testing in progress and removed Progress: ready for testing labels

engcom-Charlie added the Auto-Tests: Covered label

ghost added Progress: extended testing and removed Progress: testing in progress labels

Contributor

engcom-Charlie commented Dec 18, 2019

✔️ QA Passed

engcom-Golf self-assigned this

ghost added Progress: accept and removed Progress: extended testing labels

Contributor Author

edenduong commented Dec 18, 2019

@lbajsarowicz @engcom-Charlie: Could you please add "Test Coverage Award" for this PR :) Thanks :D

Contributor

lbajsarowicz commented Dec 18, 2019

Sure. I was not into these awards yet. 👍

lbajsarowicz added the Award: test coverage label

magento-engcom-team pushed a commit that referenced this pull request


          ENGCOM-6496: [GiftMessage] Cover Observer SalesEventOrderItemToQuoteI…

de3a2de

…temObserver by Unit Test #26082

magento-engcom-team merged commit 85036fa into magento:2.4-develop

m2-assistant bot commented Dec 19, 2019

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment