Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activated "Pending Reviews" menu item when merchant opens 'Pending Reviews' section #26230

Merged
merged 4 commits into from Feb 26, 2020
Merged

Activated "Pending Reviews" menu item when merchant opens 'Pending Reviews' section #26230

merged 4 commits into from Feb 26, 2020

Conversation

rav-redchamps
Copy link
Contributor

Description (*)

This pull request will activate the "Pending Reviews" menu item when merchant opens admin path 'Marketing > User Content > Pending Reviews'

Fixed Issues (if relevant)

  1. Active menu is not set when opening admin path Marketing > User Content > Pending Reviews #26229 >: Active menu is not set when opening admin path Marketing > User Content > Pending Reviews

Manual testing scenarios (*)

  1. Go to admin path 'Marketing > User Content > Pending Reviews' & notice that 'Marketing' menu item is now shown as active

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @rav-redchamps. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rav-redchamps
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps, here is your new Magento instance.
Admin access: https://pr-26230.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rav-redchamps
Copy link
Contributor Author

Verified on the test instance. Change works well

@rav-redchamps rav-redchamps mentioned this pull request Jan 2, 2020
Closed
@dmytro-ch dmytro-ch self-assigned this Jan 2, 2020
dmytro-ch
dmytro-ch requested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rav-redchamps, thank you for your contribution. Due to Magento Definition of Done the changes should be covered by tests. Could you please cover your fix by automated tests?
I think the functional test is preferable in this particular case.
Thank you!

@dmytro-ch dmytro-ch added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jan 2, 2020
@rav-redchamps
Copy link
Contributor Author

Hello @rav-redchamps, thank you for your contribution. Due to Magento Definition of Done the changes should be covered by tests. Could you please cover your fix by automated tests?
I think the functional test is preferable in this particular case.
Thank you!

I just added the function test. Please feel free to let me know if anything else is required.

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo self-assigned this Jan 31, 2020
@dmytro-ch dmytro-ch added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage labels Feb 2, 2020
dmytro-ch
dmytro-ch reviewed Feb 3, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rav-redchamps. Sorry for the late reply and thank you for your patience.
Could you please add at least one assertion to your test which covers the issue fixed in this PR. Currently it does not actually verify whether the menu item is active or not.
Thank you!

app/code/Magento/Review/Test/Mftf/Test/AdminMarketingPendingReviewsNavigateMenuTest.xml Outdated Show resolved Hide resolved
@dmytro-ch dmytro-ch removed the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Feb 3, 2020
@engcom-Echo
Copy link
Contributor

I will take to fix MFTF

@dmytro-ch
Copy link
Contributor

@engcom-Echo, great, thank you! :)

@ghost ghost dismissed dmytro-ch’s stale review February 20, 2020 12:54

Pull Request state was updated. Re-review required.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6938 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6938 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Feb 24, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6938 has been created to process this Pull Request

magento-engcom-team pushed a commit that referenced this pull request Feb 26, 2020
@slavvka
ENGCOM-6938: Activated "Pending Reviews" menu item when merchant open…
177e972 
…s 'Pending Reviews' section #26230
@magento-engcom-team magento-engcom-team merged commit 4ed1fa0 into magento:2.4-develop Feb 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @rav-redchamps, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@akaplya akaplya Awaiting requested review from akaplya

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Component: Review Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rav-redchamps @magento-engcom-team @engcom-Echo @dmytro-ch @engcom-Alfa