-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-26255: Refactor CacheInvalidate sendPurgeRequest to fix incorrect tag splitting #26256
GH-26255: Refactor CacheInvalidate sendPurgeRequest to fix incorrect tag splitting #26256
Conversation
…orrect purge batching, regardless of the size and content of provided tag pattern.
Hi @moloughlin. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
…rams. Fix failing test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide some Unit Tests for that changes?
@lbajsarowicz, I've added a test for the splitting of large tag arrays and fixed the other outstanding suggestions. Ready for another look when you are available - thanks! |
Added test coverage as requested.
@lbajsarowicz can you please confirm next steps on this? Thanks. |
@magento run all tests |
@moloughlin Let's wait for tests to pass. Could you eventually merge latest |
…lidate_incorrect_tag_splitting
@lbajsarowicz awesome, thanks. 2.4-develop merged back in and only the typical false negatives on the test runs 👍 |
…lidate_incorrect_tag_splitting
Bump (merged 2.4-develop again since it's been a few weeks...) |
@moloughlin Thanks for your contribution (again). After tests pass - I'm going to approve the PR. |
Hi @lbajsarowicz, thank you for the review.
|
Failed Functional Tests B2B is not related to changes in current Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @engcom-Kilo are tested this fix with varnish? If not please retest it.
@VladimirZaets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved again in order to have an ability to move back to accept
Hi @ihor-sviziev, thank you for the review. |
…ix incorrect tag splitting #26256
Hi @moloughlin, thank you for your contribution! |
Description (*)
Issue: #26255
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)