Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14913 - bookmark views become uneditable after deleting the first bookmark view #26263

Conversation

Bartlomiejsz
Copy link
Contributor

@Bartlomiejsz Bartlomiejsz commented Jan 4, 2020

Description (*)

This is fix for #14913

Fixed Issues (if relevant)

  1. bookmark views become uneditable after deleting the first bookmark view. #14913: bookmark views become uneditable after deleting the first bookmark view

Manual testing scenarios (*)

Check issue fixed for testing steps

Questions or comments

This is only change in template, it doesn't change structure or any scripts, so not sure what tests could be provided.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 4, 2020

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@nuzil
Copy link
Contributor

nuzil commented Jan 6, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

@nuzil nuzil self-assigned this Jan 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, here is your new Magento instance.
Admin access: https://pr-26263.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@nuzil nuzil added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-6546 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Bartlomiejsz Bartlomiejsz deleted the feature/fix_14913_bookmarks_uneditable branch January 20, 2020 22:44
@Bartlomiejsz Bartlomiejsz restored the feature/fix_14913_bookmarks_uneditable branch May 28, 2020 22:27
@Bartlomiejsz Bartlomiejsz deleted the feature/fix_14913_bookmarks_uneditable branch June 23, 2020 20:38
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Ui Partner: Fast White Cat partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants