Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #26276 with clonning quote billing address street #26279

Conversation

yutv
Copy link

@yutv yutv commented Jan 6, 2020

Description (*)

Fixed cloning billing address to do it recursively including the street array.

Fixed Issues (if relevant)

  1. Checkout. Quote Address Street cloning issue #26276: Checkout. Quote Address Street cloning issue

Manual testing scenarios (*)

  1. Register an customer account

  2. Add an address and mark it as billing and shipping

  3. Go to the second step of checkout

  4. Run the following code in the developer console

     # Output and remember what is shipping address city and street
     require('Magento_Checkout/js/model/quote').shippingAddress().city
     require('Magento_Checkout/js/model/quote').shippingAddress().street[0]
    
     # change the billing address City and Street
     require('Magento_Checkout/js/model/quote').billingAddress().city = "Test"
     require('Magento_Checkout/js/model/quote').billingAddress().street[0] = "123 Main street"
    
     # Check if shipping address city and street are changed (they should not change after the fix)
     require('Magento_Checkout/js/model/quote').shippingAddress().city
     require('Magento_Checkout/js/model/quote').shippingAddress().street[0]
    

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@yutv yutv requested a review from DrewML as a code owner January 6, 2020 11:04
@m2-assistant
Copy link

m2-assistant bot commented Jan 6, 2020

Hi @yutv. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@nuzil
Copy link
Contributor

nuzil commented Jan 6, 2020

@yutv
can you please sign CLA?

@nuzil nuzil self-assigned this Jan 6, 2020
@yutv
Copy link
Author

yutv commented Jan 15, 2020

@yutv
can you please sign CLA?

Signed

@nuzil nuzil added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 15, 2020
@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-6615 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@yutv thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
after

After:
before

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@magento-engcom-team magento-engcom-team merged commit 974f5e9 into magento:2.4-develop Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @yutv, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants