Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed Jump Datepicker issue in Catalog Price Rule] #26290

Conversation

hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Jan 7, 2020

Description (*)

Fixed Jump Datepicker issue in Catalog Price Rule

Fixed Issues (if relevant)

  1. Jump Datepicker in Catalog Price Rule #26289: Jump Datepicker in Catalog Price Rule

Manual testing scenarios (*)

  1. Login to Backend
  2. Go to Marketing => Promotions => Catalog Price Rule
  3. Click on Datepicker

Expected result

  1. Datepicker does not jump in Catalog Price Rule
    expected

Actual result

  1. Jump Datepicker in Catalog Price Rule
    actual

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 7, 2020

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jan 7, 2020
@ptylek
Copy link
Contributor

ptylek commented Jan 7, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ptylek. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-26290.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned ptylek Jan 7, 2020
@ptylek ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6550 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @hitesh-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hitesh-wagento hitesh-wagento deleted the fixed-datepickerjump-hitesh branch January 17, 2020 10:07
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants